Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when picking host for transfer-image #850

Merged
merged 2 commits into from
May 21, 2023
Merged

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented May 20, 2023

When picking a host for transfer-image job, we filter hosts that are UP and then process the data they reported on storage domains without checking whether the host actually reported this data. It can happen that hosts are UP and still have not reported data on storage domains, in which case the data is null, resulting in an NPE in the transfer-image flow.

This patch changes the predicate that is used to filter hosts for transfer-image, adding a null-check to avoid that NPE.

Bug-Url: https://bugzilla.redhat.com/2203132

When picking a host for transfer-image job, we filter hosts that
are UP and then process the data they reported on storage domains
without checking whether the host actually reported this data.
It can happen that hosts are UP and still have not reported data
on storage domains, in which case the data is null, resulting in
an NPE in the transfer-image flow.

This patch changes the predicate that is used to filter hosts for
transfer-image, adding a null-check to avoid that NPE.

Bug-Url: https://bugzilla.redhat.com/2203132
Signed-off-by: Arik Hadas <ahadas@redhat.com>
@ahadas ahadas requested a review from bennyz as a code owner May 20, 2023 20:52
@ahadas
Copy link
Member Author

ahadas commented May 21, 2023

/ost

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's disable the ansible-lint until we figure out how to fix it

@ahadas
Copy link
Member Author

ahadas commented May 21, 2023

OK, let's disable the ansible-lint until we figure out how to fix it

ack, I planned to drop this commit after seeing that OST passes but if we're ok with commenting it out, I'd change the commit message

The call to ansible-lint is commented out until we fix it
Filed issue: oVirt#851

Signed-off-by: Arik Hadas <ahadas@redhat.com>
@ahadas ahadas merged commit 5c0a616 into oVirt:master May 21, 2023
@ahadas ahadas deleted the bug_2203132 branch May 21, 2023 10:50
This was referenced May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants